fix(ws): Songbird would fail if it could not deserialize ws payload. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erk-
force-pushed
the
do-not-fail-if-new-opcode
branch
from
1d9d135
to
0618112
Compare
This was referenced Apr 8, 2023
|
updated my project with pr-branch, appears to work great. |
FelixMcFelix
approved these changes
Apr 9, 2023
Merged
Erk-
added a commit
to Erk-/songbird
that referenced
this pull request
Apr 10, 2023
…ayload. (serenity-rs#170)" This reverts commit 752cae7.
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
Apr 10, 2023
…erenity-rs#170) Receiving a new opcode while connecting to a voice channel was causing the connection to fail, while this was handled correctly elsewhere. Unfortunately, Discord added such a payload during every connection. This PR moves the logging and conversion to no-op (and log) to catch both locations.
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
Nov 20, 2023
…erenity-rs#170) Receiving a new opcode while connecting to a voice channel was causing the connection to fail, while this was handled correctly elsewhere. Unfortunately, Discord added such a payload during every connection. This PR moves the logging and conversion to no-op (and log) to catch both locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord started sending a new event on the voice websocket with opcode 18:
{"op":18,"d":{"user_id":"...","flags":0}}This caused songbird to crash and disconnect.
This patch makes it so that failing to deserialize a event is not a fatal error.