-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Serilog v4, remove reference to Serilog.Sinks.PeriodicBatching #543
Comments
The PR was merged. Thank you very much for the contribution @cancakar35! @cremor, @cancakar35 and everyone interested: now the dev branch was updated with the contribution a dev packages was built and published on nuget.org. Could you please give this version a spin and let me know if it works fine or you see any new issues with it? https://www.nuget.org/packages/Serilog.Sinks.MSSqlServer/7.0.0-dev-00087 If the feedback on the dev package is good, I will merge dev into main and produce a latest release 7.0.0. |
I've ran a quick test in my solution and everything seems to work fine. Thanks! |
* Fixed issue #543: Update to Serilog v4, remove reference to Serilog.Sinks.PeriodicBatching (thanks to @cancakar35) * Full automatic release and run on ubuntu-latest agent * Added developer documentation * Enabled .NET package validation
@cremor Thanks for testing with the prerelease. |
This seems to have crept back in on 7.0.1, getting errors about missing PeriodicBatching on a deployed application that's been updated to this version. |
@elylv See #566 (comment) |
Hi @elylv , #564 (comment) this should help. Also if your project targets .net framework, please check your assembly bindings in web.config/app.config file. |
From the Serilog.Sinks.PeriodicBatching readme:
Therefore I suggest to release a new major version of this sink which directly uses
IBatchedLogEventSink
from Serilog and doesn't have a reference to Serilog.Sinks.PeriodicBatching any more.The text was updated successfully, but these errors were encountered: