Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Serilog v4, remove reference to Serilog.Sinks.PeriodicBatching #543

Closed
cremor opened this issue Jun 12, 2024 · 6 comments
Closed

Comments

@cremor
Copy link

cremor commented Jun 12, 2024

From the Serilog.Sinks.PeriodicBatching readme:

Serilog 4.x and later versions support batching natively. New projects should use Serilog's IBatchedLogEventSink and WriteTo.Sink(IBatchedLogEventSink), not this package which is now only maintained for compatibility reasons.

Therefore I suggest to release a new major version of this sink which directly uses IBatchedLogEventSink from Serilog and doesn't have a reference to Serilog.Sinks.PeriodicBatching any more.

@ckadluba
Copy link
Member

ckadluba commented Sep 4, 2024

The PR was merged. Thank you very much for the contribution @cancakar35!

@cremor, @cancakar35 and everyone interested: now the dev branch was updated with the contribution a dev packages was built and published on nuget.org. Could you please give this version a spin and let me know if it works fine or you see any new issues with it?

https://www.nuget.org/packages/Serilog.Sinks.MSSqlServer/7.0.0-dev-00087

If the feedback on the dev package is good, I will merge dev into main and produce a latest release 7.0.0.

@cremor
Copy link
Author

cremor commented Sep 5, 2024

I've ran a quick test in my solution and everything seems to work fine. Thanks!

@ckadluba ckadluba mentioned this issue Sep 9, 2024
ckadluba added a commit that referenced this issue Sep 9, 2024
* Fixed issue #543: Update to Serilog v4, remove reference to Serilog.Sinks.PeriodicBatching (thanks to @cancakar35)
* Full automatic release and run on ubuntu-latest agent
* Added developer documentation
* Enabled .NET package validation
@ckadluba ckadluba closed this as completed Sep 9, 2024
@ckadluba
Copy link
Member

ckadluba commented Sep 9, 2024

@cremor Thanks for testing with the prerelease.

@elylv
Copy link

elylv commented Oct 3, 2024

This seems to have crept back in on 7.0.1, getting errors about missing PeriodicBatching on a deployed application that's been updated to this version.

@cremor
Copy link
Author

cremor commented Oct 3, 2024

@elylv See #566 (comment)

@cancakar35
Copy link
Member

Hi @elylv , #564 (comment) this should help. Also if your project targets .net framework, please check your assembly bindings in web.config/app.config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants