diff --git a/lib/apiGateway/methods.js b/lib/apiGateway/methods.js index 15f16e1..e9026f9 100644 --- a/lib/apiGateway/methods.js +++ b/lib/apiGateway/methods.js @@ -33,14 +33,9 @@ module.exports = { } if (http && http.cors) { - let origin = http.cors.origin - if (http.cors.origins && http.cors.origins.length) { - origin = http.cors.origins.join(',') - } - methodResponse.Properties.MethodResponses.forEach((val, i) => { methodResponse.Properties.MethodResponses[i].ResponseParameters = { - 'method.response.header.Access-Control-Allow-Origin': `'${origin}'` + 'method.response.header.Access-Control-Allow-Origin': true } }) } diff --git a/lib/apiGateway/methods.test.js b/lib/apiGateway/methods.test.js index cd143ff..02bfa2a 100644 --- a/lib/apiGateway/methods.test.js +++ b/lib/apiGateway/methods.test.js @@ -42,7 +42,7 @@ describe('#getAllServiceProxies()', () => { json1.Properties.MethodResponses[0].ResponseParameters[ 'method.response.header.Access-Control-Allow-Origin' ] - ).to.equal("'*'") + ).to.equal(true) const json2 = serverlessApigatewayServiceProxy.getMethodResponses({ cors: { @@ -54,7 +54,7 @@ describe('#getAllServiceProxies()', () => { json2.Properties.MethodResponses[0].ResponseParameters[ 'method.response.header.Access-Control-Allow-Origin' ] - ).to.equal("'*,http://example.com'") + ).to.equal(true) }) }) }) diff --git a/lib/package/dynamodb/compileMethodsToDynamodb.test.js b/lib/package/dynamodb/compileMethodsToDynamodb.test.js index c363d5a..317839a 100644 --- a/lib/package/dynamodb/compileMethodsToDynamodb.test.js +++ b/lib/package/dynamodb/compileMethodsToDynamodb.test.js @@ -839,17 +839,17 @@ describe('#compileMethodsToDynamodb()', () => { }, MethodResponses: [ { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 200 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 400 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 500 } diff --git a/lib/package/eventbridge/compileMethodsToEventBridge.test.js b/lib/package/eventbridge/compileMethodsToEventBridge.test.js index 66cbcc0..a21ed8b 100644 --- a/lib/package/eventbridge/compileMethodsToEventBridge.test.js +++ b/lib/package/eventbridge/compileMethodsToEventBridge.test.js @@ -243,17 +243,17 @@ describe('#compileMethodsToEventBridge()', () => { }, MethodResponses: [ { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 200 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 400 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 500 } diff --git a/lib/package/kinesis/compileMethodsToKinesis.test.js b/lib/package/kinesis/compileMethodsToKinesis.test.js index 21352e3..647b655 100644 --- a/lib/package/kinesis/compileMethodsToKinesis.test.js +++ b/lib/package/kinesis/compileMethodsToKinesis.test.js @@ -229,17 +229,17 @@ describe('#compileMethodsToKinesis()', () => { }, MethodResponses: [ { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 200 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 400 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 500 } diff --git a/lib/package/sns/compileMethodsToSns.test.js b/lib/package/sns/compileMethodsToSns.test.js index 49a0df6..33e4a00 100644 --- a/lib/package/sns/compileMethodsToSns.test.js +++ b/lib/package/sns/compileMethodsToSns.test.js @@ -255,17 +255,17 @@ describe('#compileMethodsToSns()', () => { }, MethodResponses: [ { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 200 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 400 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 500 } diff --git a/lib/package/sqs/compileMethodsToSqs.test.js b/lib/package/sqs/compileMethodsToSqs.test.js index ca87423..209ab82 100644 --- a/lib/package/sqs/compileMethodsToSqs.test.js +++ b/lib/package/sqs/compileMethodsToSqs.test.js @@ -205,17 +205,17 @@ describe('#compileMethodsToSqs()', () => { }, MethodResponses: [ { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 200 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 400 }, { - ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': "'*'" }, + ResponseParameters: { 'method.response.header.Access-Control-Allow-Origin': true }, ResponseModels: {}, StatusCode: 500 } diff --git a/package-lock.json b/package-lock.json index 58a9452..239169c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "serverless-apigateway-service-proxy", - "version": "2.2.0", + "version": "2.2.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "serverless-apigateway-service-proxy", - "version": "2.2.0", + "version": "2.2.1", "license": "MIT", "dependencies": { "@hapi/joi": "^15.1.0",