Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

fix: Update GitHub Issue and PR templates #353

Merged
merged 1 commit into from
Oct 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: Feature request
about: Suggest an idea for serverless framework
about: Suggest an idea for serverless-azure-functions
---

<!--
Expand Down
9 changes: 4 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,20 @@ to review a PR, the faster we can review and merge it.
Examples:
* serverless.yml - Fully functioning to easily deploy changes
* Screenshots - Showing the difference between your output and the master
* Cloud Configuration - List cloud resources and show that the correct configuration is in place (e.g. AWS CLI commands)
* Cloud Configuration - List cloud resources and show that the correct configuration is in place
* Other - Anything else that comes to mind to help us evaluate
-->

## Todos:

_**Note: Run `npm run test:ci` to run all validation checks on proposed changes**_

- [ ] Write tests and confirm existing functionality is not broken.
**Validate via `npm test`**
- [ ] Write documentation
- [ ] Ensure there are no lint errors.
**Validate via `npm run lint`**
_Note: Some reported issues can be automatically fixed by running `npm run lint:fix`_
- [ ] Make sure code coverage hasn't dropped
- [ ] Write tests and confirm existing functionality is not broken.
**Validate via `npm test`**
- [ ] Write documentation
- [ ] Provide verification config / commands / resources
- [ ] Enable "Allow edits from maintainers" for this PR
- [ ] Update the messages below
Expand Down