From 1155591ecc1685656568dc7e37622e083a653729 Mon Sep 17 00:00:00 2001 From: Gligor Kotushevski Date: Tue, 16 May 2023 09:06:24 +1200 Subject: [PATCH 1/4] Only run tag if new version on the main repo, not on forks --- .github/workflows/integration.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index d4a4b8c8..81ec766f 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -194,6 +194,7 @@ jobs: tag-if-new-version: runs-on: ubuntu-latest needs: [node-integration-tests, python-integration-tests] + if: github.repository_owner == 'serverless' steps: - name: Checkout repository From 3ff9fd90531f0ce218617691f0f5604d869ebbcb Mon Sep 17 00:00:00 2001 From: Gligor Kotushevski Date: Wed, 17 May 2023 08:25:49 +1200 Subject: [PATCH 2/4] fixing GitHub tag name for GitHub release publishing --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index f96de9a5..5f2bc614 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -54,6 +54,6 @@ jobs: - name: Create and publish a release uses: softprops/action-gh-release@v1 with: - tag_name: ${GITHUB_REF##*/} + tag_name: ${{ github.ref_name }} prerelease: false generate_release_notes: true From 98ce406b93ee9cb5e6b390aeeaeaa0bc7090c3b8 Mon Sep 17 00:00:00 2001 From: Gligor Kotushevski Date: Wed, 17 May 2023 08:31:05 +1200 Subject: [PATCH 3/4] add missing build step to publish script --- .github/workflows/publish.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 5f2bc614..87d65c6c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -44,6 +44,9 @@ jobs: run: | npm ci + - name: Build local package + run: npm pack + - name: Publish new version # Note: Setting NODE_AUTH_TOKEN as job|workspace wide env var won't work # as it appears actions/setup-node sets own value From bf5a680c85c7b1c65963b18c2985dbfbd948d9a0 Mon Sep 17 00:00:00 2001 From: Gligor Kotushevski Date: Wed, 17 May 2023 08:34:43 +1200 Subject: [PATCH 4/4] updated build step --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 87d65c6c..bf3ebcf8 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -45,7 +45,7 @@ jobs: npm ci - name: Build local package - run: npm pack + run: npm run build - name: Publish new version # Note: Setting NODE_AUTH_TOKEN as job|workspace wide env var won't work