From 698d429e19febc04b303591cde8ef722bb346420 Mon Sep 17 00:00:00 2001 From: spolti Date: Wed, 21 Sep 2022 15:44:52 -0300 Subject: [PATCH 1/2] v08 spec alignment - Workflow start no longer a required property Signed-off-by: spolti --- model/workflow.go | 2 +- parser/parser_test.go | 1 + parser/testdata/workflows/greetings-v08-spec.sw.yaml | 2 -- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/model/workflow.go b/model/workflow.go index bbaca6c..dc244c4 100644 --- a/model/workflow.go +++ b/model/workflow.go @@ -63,7 +63,7 @@ type BaseWorkflow struct { Description string `json:"description,omitempty"` // Workflow version Version string `json:"version" validate:"omitempty,min=1"` - Start *Start `json:"start" validate:"required"` + Start *Start `json:"start" validate:"omitempty"` // Annotations List of helpful terms describing the workflows intended purpose, subject areas, or other important qualities Annotations []string `json:"annotations,omitempty"` // DataInputSchema URI of the JSON Schema used to validate the workflow data input diff --git a/parser/parser_test.go b/parser/parser_test.go index 3c019de..d9d02cd 100644 --- a/parser/parser_test.go +++ b/parser/parser_test.go @@ -68,6 +68,7 @@ func TestFromFile(t *testing.T) { }, "./testdata/workflows/greetings-v08-spec.sw.yaml": func(t *testing.T, w *model.Workflow) { assert.Empty(t, w.Name) + assert.Empty(t, w.Start) assert.IsType(t, &model.OperationState{}, w.States[0]) assert.Equal(t, "custom.greeting", w.ID) assert.NotEmpty(t, w.States[0].(*model.OperationState).Actions) diff --git a/parser/testdata/workflows/greetings-v08-spec.sw.yaml b/parser/testdata/workflows/greetings-v08-spec.sw.yaml index f5858dd..756f801 100644 --- a/parser/testdata/workflows/greetings-v08-spec.sw.yaml +++ b/parser/testdata/workflows/greetings-v08-spec.sw.yaml @@ -16,8 +16,6 @@ id: custom.greeting version: '1.0' description: Greet Someone specVersion: "0.8" -start: - stateName: Greet functions: - name: greetingCustomFunction operation: /path/to/my/script/greeting.ts#CustomGreeting From 55cb62652de3196dcda6c1ec3e7de1080e30251b Mon Sep 17 00:00:00 2001 From: spolti Date: Thu, 29 Sep 2022 12:53:57 -0300 Subject: [PATCH 2/2] Update model/workflow.go Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Signed-off-by: spolti --- model/workflow.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/workflow.go b/model/workflow.go index dc244c4..ba86143 100644 --- a/model/workflow.go +++ b/model/workflow.go @@ -63,7 +63,7 @@ type BaseWorkflow struct { Description string `json:"description,omitempty"` // Workflow version Version string `json:"version" validate:"omitempty,min=1"` - Start *Start `json:"start" validate:"omitempty"` + Start *Start `json:"start,omitempty"` // Annotations List of helpful terms describing the workflows intended purpose, subject areas, or other important qualities Annotations []string `json:"annotations,omitempty"` // DataInputSchema URI of the JSON Schema used to validate the workflow data input