Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET6 + ProtoBuf #28

Merged
merged 13 commits into from
Feb 10, 2022
Merged

NET6 + ProtoBuf #28

merged 13 commits into from
Feb 10, 2022

Conversation

cdavernas
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Updates solution to NET 6.0
  • Replaced Newtonsoft JSON specific type usage (Jtoken, JObjects, ...) by (partially) serializer agnostic ones (Any, OneOf<T1,T2>)
  • Added support for ProtoBuf serialization
  • Added support for DataContact based serialization
  • Added both schema-based spec validation support and fluent spec validation to the WorkflowReader's validation logic

Special notes for reviewers:

A YAML related issue has been introduced, making the reader throw an exception when dealing with AnyOf<T1, T2> instances, when a T2 value is used. The issue is related to aaubry/YamlDotNet#675

- Added the OneOf and Any types, as well as related converters
- Replaced JToken and JObject properties by OneOf and Any properties
- Updated the WorkflowBuilder by checking against null references
- Renamed the DelayState into SleepState
- Added new tests
- Added the OneOf and Any types, as well as related converters
- Replaced JToken and JObject properties by OneOf and Any properties
- Updated the WorkflowBuilder by checking against null references
- Renamed the DelayState into SleepState
- Added new tests
@tsurdilo
Copy link
Contributor

@cdavernas wow thanks!! this is awesome

Updated SDK version to 0.7.9
@cdavernas cdavernas merged commit fd19f8c into serverlessworkflow:main Feb 10, 2022
@cdavernas cdavernas deleted the protobuf branch February 10, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants