Add support for text-minimap (WIP)
#53
Conversation
This makes this plugin smooth as butter.
|
|
||
| # TODO: this check could be done once at the start | ||
| #text_minimap_path = shutil.which("text-minimap") | ||
| #if text_minimap_path is None: |
There was a problem hiding this comment.
Why not using a snippet like that: http://stackoverflow.com/a/377028/828379 to check whether text-minimap is available?
There was a problem hiding this comment.
No idea. I tried shutil.which in repl and it worked. And I'm getting syntax error that I can't understand, so I am puzzled.
There was a problem hiding this comment.
Well, the reason is that which has been added to shutil in Python 3, but does not exist in Python 2 :-)
There was a problem hiding this comment.
Oh. Thanks for helping me with this. That would explain it...
¯_(ツ)_/¯ Python...
Anyway, I've been using this plugin with my changes and there are some weird things going on with selection on the original source code buffer, and I'm not sure if it's because of my changes. Need to investigate. Just letting you know.
Though I'm really happy about the speed now. :)
There was a problem hiding this comment.
Ok. I let you first update your PR with the suggested code to detect text-minimap, then investigate the selection issue. I'll merge your PR as soon as you think it is ready.
There was a problem hiding this comment.
So it's not a problem with this patch. Sometimes redrawing the minimap messes with the current visual selection.
There was a problem hiding this comment.
smooth my ass... its nightmare :( why so lagging on my nvim?
|
Any news on this? Merging this would be awesome. |
|
Someone will have to take over and help me finish. |
|
Is it just the weird issues with selection of the original source? Or are there other problems? |
|
The visual selection was malfunctioning with it. |
This makes this plugin smooth as butter.