Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the environment variables created by the parent process for … #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

David-wanghw
Copy link

…the next call.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   15.89%   15.89%           
=======================================
  Files          10        8    -2     
  Lines         258      258           
=======================================
  Hits           41       41           
  Misses        212      212           
  Partials        5        5           
Impacted Files Coverage Δ
daemon_unix.go 0.00% <0.00%> (ø)
syscall_dup.go
os_executable.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf83969...61adefb. Read the comment docs.

@NorseGaud
Copy link
Contributor

This seems to work, but I have no idea what the scenario is to test. @David-wanghw , any ideas?

Also, shouldn't d.clearEnv() come at the top of the child function?

@sevlyar
Copy link
Owner

sevlyar commented Apr 6, 2024

The change may break backward compatibility: function WasReborn() won't work properly after Reborn() call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants