-
Notifications
You must be signed in to change notification settings - Fork 36
Pin to Dask 2021.02.0 while incompatibility with later versions is investigated #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will fix the main build and the documentation build (see #482). |
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to pin in setup.cfg? This does more than just fix the CI builds, doesn't it?
You're right. I was hoping this pin would be short-lived, and certainly wouldn't get released. I can just change the requirements file though for CI. |
Pins have a habit of persisting, I'd rather keep it to a minimum, but it's up to you really. |
|
I'd be curious to know what changes in the Dask 2021.03.0 release impacted |
It was this Dask PR: dask/dask#6738. I see the problem described in #482 with that commit, but not with the one before it. More concretely, the following prints import numpy as np
import xarray as xr
import dask.array as da
xr.DataArray.__module__ = "xarray" # simulate sphinx workaround, which has the effect of Dask not recognising it as xarray
data = np.arange(4)
da.asarray(xr.DataArray(data)).max().compute() |
|
Gotcha, thanks for the upstream PR in Dask! |
No description provided.