From 360ba059496f2e52cfa6bfd7572c808d7802d47f Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Fri, 10 Jul 2020 13:46:25 +0100 Subject: [PATCH] Attempt to fix chromium builds It would seem that `glslang_sources` has a private dependency on `glslang_build_info`, so `glslang_validator` cannot transitively `#include` the generated `glslang/build_info.h` header. Add `glslang_build_info` as a direct dependency to `glslang_validator`. Also remove the duplicate dependency on `glslang_build_info` in `glslang_sources_common` Note: This is a speculative fix as I can build Chromium fine without these changes. Not sure what's different between these configs. --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 09a0c719de..7242b6f373 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -242,7 +242,6 @@ template("glslang_sources_common") { if (invoker.enable_opt) { deps += [ - ":glslang_build_info", "${spirv_tools_dir}:spvtools_opt", "${spirv_tools_dir}:spvtools_val", ] @@ -289,6 +288,7 @@ executable("glslang_validator") { deps = [ ":glslang_default_resource_limits_sources", ":glslang_sources", + ":glslang_build_info", ] public_configs = [ ":glslang_hlsl" ]