Transfer offset decorations when legalizing laid-out structs #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 8, 2024
Format code for PR shader-slang#5525
csyonghe
reviewed
Nov 8, 2024
csyonghe
reviewed
Nov 8, 2024
csyonghe
reviewed
Nov 8, 2024
Struct legalization removing fields not representable in memory should transfer all decorations in case the struct has already had offsets calculated. Closes shader-slang#5264.
aleino-nv
force-pushed
the
aleino/nullptr-deref
branch
from
3e66d2b
to
24aec7f
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#5525
csyonghe
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struct legalization removing fields not representable in memory should transfer offset decorations in case the struct has already had offsets calculated.
Closes #5264.