Testing improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now if there are multiple tests listed for an input file like `foo.slang`, they will be output as:
passed test: 'foo.slang'
passed test: 'foo.slang.1'
passed test: 'foo.slang.2'
This isn't a perfect solution, but it should work well enough for now.
This change doesn't make any tests actually use the new capability.
Most of the Vulkan GLSL shaders in the `sascha-willems` corpus use completely regular parameter bindings, e.g.: ``` layout (binding = 0) uniform sampler2D samplerPositionDepth; layout (binding = 1) uniform sampler2D samplerNormal; layout (binding = 2) uniform sampler2D ssaoNoise; ``` With the Slang compiler, we can write this kind of stuff more compactly as: ``` uniform sampler2D samplerPositionDepth; uniform sampler2D samplerNormal; uniform sampler2D ssaoNoise; ``` and get the exact same result (in fact, we will generate output GLSL matching the first example). There are a few spot tests for this in the HLSL case, but I hadn't done anything for GLSL yet. Now that we have the ability to specify multiple tests to run on each input file, it was easy enough to go in and tweak some of these files to be usable as binding-generation tests. I didn't ammend all of the GLSL shaders for two reasons: 1. Not all of the shaders will work with completely automatic binding generation done on a per-file basis. In some cases, the parameter layout needs to consider multiple files (and the order in which the files are supplied could matter). This is probably best handled with more directed tests. 2. There is going to be a ton of duplication if I just have 100s of tests that all confirm that, yes, the Slang compiler can count vertex inputs starting from zero. These shaders aren't really presenting a whole lot of unique cases to work with. That said, a level of confidence greater than zero is always better than zero confidence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two pieces here:
Upgrade the test runner to support multiple tests per input file
Use that capability to make some of the
sascha-willemsGLSL tests serve double duty as tests for binding generationThis covers the easy aspects of binding generation, but I'll probably need some more directed tests to cover constant buffer layout.