From 8ef507fa857c4cb7de20db5752e804d63c1d8960 Mon Sep 17 00:00:00 2001 From: Shahzad Lone Date: Tue, 26 Nov 2024 03:27:19 +0800 Subject: [PATCH] PR(FEEDBACK): Add documentation to the "*" safeguard --- tests/integration/identity.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/integration/identity.go b/tests/integration/identity.go index 3043373805..f0a5a5aff1 100644 --- a/tests/integration/identity.go +++ b/tests/integration/identity.go @@ -96,6 +96,10 @@ func getIdentity(s *state, identity immutable.Option[identity]) acpIdentity.Iden if !identity.HasValue() { return acpIdentity.Identity{} } + + // The selector must never be "*" here because this function returns a specific identity from the + // stored identities, if "*" string needs to be signaled to the acp module then it should be handled + // a call before this function. if identity.Value().selector == "*" { require.Fail(s.t, "Used the \"*\" selector for identity incorrectly.", s.testCase.Description) }