Skip to content

Commit 04f2c49

Browse files
ihabadhamclaude
andcommitted
perf: Optimize add_react_on_rails_package to eliminate redundant array conversions
Address Justin's minor optimization suggestion: - Use add_js_dependencies_batch instead of add_js_dependency for single package - Work with arrays consistently throughout the method flow - Eliminates unnecessary string→array→string conversions - Maintains identical functionality with improved efficiency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 0b6a7c5 commit 04f2c49

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lib/generators/react_on_rails/js_dependency_manager.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,15 +76,17 @@ def add_react_on_rails_package
7676
"react-on-rails"
7777
end
7878

79+
packages_array = [react_on_rails_pkg]
80+
7981
puts "Installing React on Rails package..."
80-
if add_js_dependency(react_on_rails_pkg)
82+
if add_js_dependencies_batch(packages_array)
8183
@added_dependencies_to_package_json = true
8284
else
8385
# Fallback to direct npm install
8486
puts "Using direct npm commands as fallback"
85-
success = system("npm", "install", react_on_rails_pkg)
87+
success = system("npm", "install", *packages_array)
8688
@ran_direct_installs = true if success
87-
handle_npm_failure("react-on-rails package", [react_on_rails_pkg]) unless success
89+
handle_npm_failure("react-on-rails package", packages_array) unless success
8890
end
8991
end
9092

0 commit comments

Comments
 (0)