-
-
Notifications
You must be signed in to change notification settings - Fork 638
Open
Labels
Description
Summary
Improve CI workflows and build scripts for better reliability and consistency.
Background
PR #1896 contained several CI and build improvements. This issue tracks extracting those that are still relevant for current master.
Proposed Changes
1. Fix Prepack Scripts
- Ensure prepack scripts use
yarninstead ofnpm - Consistency across all package.json files
- Update package-scripts.yml
Files:
package-scripts.yml
packages/react-on-rails/package.json
packages/react-on-rails-pro/package.json
2. Yalc Workflow Fixes (if still needed)
- Fix CI frozen-lockfile errors with yalc workflow
- Remove
--frozen-lockfilefrom dummy app install after yalc - Update Pro integration workflow
Files:
.github/workflows/pro-integration-tests.yml
3. ReScript Build Step (if still using ReScript)
- Add ReScript build step before starting development server
- Ensure proper build order
Note: Verify if ReScript is still in use before implementing this.
Investigation Needed
Before implementing, check:
- Are the yalc workflow issues still present on current master?
- Is ReScript still being used in the codebase?
- Are prepack scripts still using npm anywhere?
Testing
- Verify yalc workflow works in CI
- Test prepack scripts locally
- Ensure all CI workflows pass
- Check Pro integration tests
Related
- Extracted from closed PR Upgrade Shakapacker to 9.3.0 #1896
- May be already fixed on master - needs investigation
Labels
ci, build