Skip to content

Fix CI failures on master #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

Fix CI failures on master #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-on-rails-pro/src/ClientSideRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ You should return a React.Component always for the client side entry point.`);
}

try {
// eslint-disable-next-line @typescript-eslint/no-deprecated
unmountComponentAtNode(domNode);
} catch (e: unknown) {
const error = e instanceof Error ? e : new Error('Unknown error');
Expand Down
2 changes: 2 additions & 0 deletions packages/react-on-rails-pro/src/createReactOnRailsPro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,13 @@ export default function createReactOnRailsPro(

if (reactOnRailsPro.streamServerRenderedReactComponent) {
reactOnRailsProSpecificFunctions.streamServerRenderedReactComponent =
// eslint-disable-next-line @typescript-eslint/unbound-method
reactOnRailsPro.streamServerRenderedReactComponent;
}

if (reactOnRailsPro.serverRenderRSCReactComponent) {
reactOnRailsProSpecificFunctions.serverRenderRSCReactComponent =
// eslint-disable-next-line @typescript-eslint/unbound-method
reactOnRailsPro.serverRenderRSCReactComponent;
}

Expand Down
2 changes: 1 addition & 1 deletion spec/dummy/spec/helpers/react_on_rails_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def helper.append_javascript_pack_tag(name, **options)
it "throws an error in development if generated component isn't found" do
allow(Rails.env).to receive(:development?).and_return(true)
expect { helper.load_pack_for_generated_component("nonexisting_component", render_options) }
.to raise_error(ReactOnRails::Error, /the generated component entrypoint/)
.to raise_error(ReactOnRails::SmartError, /Auto-loaded Bundle Missing/)
end
end

Expand Down
Loading