Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.scope is never used #1

Open
viveleroi opened this issue Mar 7, 2013 · 0 comments
Open

settings.scope is never used #1

viveleroi opened this issue Mar 7, 2013 · 0 comments

Comments

@viveleroi
Copy link

I grabbed this plugin as a quick and dirt solution for some documentation and it works well, except the scope wasn't being used. I'd submit a PR but it's a tiny change.

Line 43 should be changed from:

$.find(settings.header_tags.join (', ')).not(settings.exclude).each (function () {

to:

settings.scope.find(settings.header_tags.join (', ')).not(settings.exclude).each (function () {

The original was simply finding all headers in the document but the second only finds the matches in the provided scope.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant