Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolitate cowswap helpers #8214

Open
woodenfurniture opened this issue Nov 28, 2024 · 0 comments
Open

Consolitate cowswap helpers #8214

woodenfurniture opened this issue Nov 28, 2024 · 0 comments

Comments

@woodenfurniture
Copy link
Member

Overview

Most of the duplicate helpers and logic was already consolidated in #8203, but we want more.

Consolidate cowswapTokenToAssetId and assetIdToCowswapToken helpers in swapper and consume across swapper/limit orders.

Put them in packages/swapper/src/cowswap-utils/

References and additional details

#8173 (comment)

Acceptance Criteria

No duplicate helpers between swapper and limit orders.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant