Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement order cancellation for limit orders #8203

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

woodenfurniture
Copy link
Member

Description

Implements limit order cancellation.

Includes bigboi refactoring to cowswap singing utils so the logic is shared between spot trades and limit orders, including cancellations.

Issue (if applicable)

closes #6201
closes #7921

Risk

High Risk PRs Require 2 approvals

High risk 👍

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel order flow Add signing and broadcast for cancel order
1 participant