feat: don't fetch NFTs meta from routes other than dashboard #8225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the box - we were previously fetching NFTs data in
<AppContext />
regardless of route, which was effective overfetchingIssue (if applicable)
contributes toactually closes NFT related spew on initial load #8167 - doesn't rate-limit things, but by ensuring we fetch at the right place, and not in swapper which doesn't need this data, we effectively make things much better already, and retries are already implemented by virtue of us consuming the Alchemy SDK. See NFT related spew on initial load #8167 (comment) for contextRisk
Low to none
Testing
alchemy
while in initial app trade routeEngineering
useNFTs()
and confirm it doesn't get hit on initial trade route, but only lazily when navigating to wallet routeOperations
Screenshots (if applicable)
https://jam.dev/c/175dae9c-cfc6-40c0-a691-90a7603ffefa