Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't fetch NFTs meta from routes other than dashboard #8225

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Nov 29, 2024

Description

Does what it says on the box - we were previously fetching NFTs data in <AppContext /> regardless of route, which was effective overfetching

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

Low to none

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Filter network requests for alchemy while in initial app trade route
  • Ensure no alchemy XHRs are made
  • Go to wallet route and notice how alchemy NFT data is fetched

Engineering

  • In addition to the testing above, you may want to paranoia add a breakpoint in useNFTs() and confirm it doesn't get hit on initial trade route, but only lazily when navigating to wallet route

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/175dae9c-cfc6-40c0-a691-90a7603ffefa

@gomesalexandre gomesalexandre marked this pull request as ready for review November 29, 2024 04:23
@gomesalexandre gomesalexandre requested a review from a team as a code owner November 29, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFT related spew on initial load
1 participant