feat: swapper chain flags #8226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection" and consume swapper chain flags This reverts commit 589822e.
gomesalexandre
commented
Nov 29, 2024
gomesalexandre
commented
Nov 29, 2024
| # swapper feature flags - other .env files will override these | ||
| # Swapper chain-specific flags. Use me if you're working on a swapper which brings first time swapper support for a chain, | ||
| # meaning we don't want to enable the selection for said chain in prod just yet | ||
| # Or alternatively, if we know that a given chain is very unstable and we may want to disable it in swapper altogether. |
There was a problem hiding this comment.
e.g we may want to disable BASE temporarily in a follow-up if it keeps on being too flaky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #8121 (comment) for context - this reverts the revert of the asset/chain filter predicates, while bringing in the notion of a swapper chain in instead of the previous "always disable Solana" behaviour.
Issue (if applicable)
closes #8140
Risk
Low
Testing
Engineering
Operations
My feature is a flag
Screenshots (if applicable)