fix: keepkey provider order making kk feature crashing #8227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Can't test actual KK functionality but smoke tested all functionalities related to other providers and sounds sane to me i.e no bugs nor spew related WC, WC dApps, wagmi, react-router, react-query, i18n:
https://jam.dev/c/5c78993c-75e0-43ae-a667-15324e74081d
https://jam.dev/c/bf247eb5-c8e0-4c8a-9fd1-7df8c50732cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The keepkey provider was under the ModalProvider, meaning that keepkey modals couldn't access the keepkey provider states, making the app crash
Issue (if applicable)
just found it
Risk
Maybe low? as it was completely crashing the app
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)