Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken links in computer_science/CONTRIBUTING.md. #25

Merged
merged 4 commits into from
Oct 1, 2022
Merged

Fixed broken links in computer_science/CONTRIBUTING.md. #25

merged 4 commits into from
Oct 1, 2022

Conversation

mdfaizanahmed786
Copy link
Contributor

All broken links have been fixed.

@mdfaizanahmed786 mdfaizanahmed786 changed the title All broken links fixed in computer_science/CONTRIBUTING.md. Fixed broken links in computer_science/CONTRIBUTING.md. Oct 1, 2022
shhossain
shhossain requested changes Oct 1, 2022
View reviewed changes
Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change link

CONTRIBUTING.md Outdated
@@ -1,6 +1,6 @@
## New contributor guide

To get an overview of the project, read the [README](README.md). Here are some resources to help you get started with open source contributions:
To get an overview of the project, read the [README](https://github.com/mdfaizanahmed786/computer_science/blob/contributingmd-links-fix/readme.md). Here are some resources to help you get started with open source contributions:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this link to "/readme.md" .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I've actually added my link.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Just change it and push it.

shhossain
shhossain requested changes Oct 1, 2022
View reviewed changes
Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change to /readme.md

@mdfaizanahmed786
Copy link
Contributor Author

mdfaizanahmed786 commented Oct 1, 2022 •
edited
Loading

Hi there, I updated the link.
PS: Is everything fine with the remaining links?

@shhossain
Copy link
Owner

Merging...

@shhossain shhossain merged commit c69d9c4 into shhossain:main Oct 1, 2022
@mdfaizanahmed786
Copy link
Contributor Author

I hope you've liked my work. This was my first open-source contribution. I know to understand it completely I've made some mistakes but I managed to contribute to your repository.

@shhossain
Copy link
Owner

Congratulations 🎊.

@shhossain shhossain mentioned this pull request Oct 1, 2022
Closed
@mdfaizanahmed786
Copy link
Contributor Author

Thanks! ❤️

@shhossain shhossain mentioned this pull request Oct 2, 2022
Open
@mdfaizanahmed786
Copy link
Contributor Author

Congratulations 🎊.

Hey there, can you please mark by PR as hacktober-fest? It would be a great help.

@shhossain
Copy link
Owner

@mdfaizanahmed786 To get "hactoberfest-accepted" label you need to add info and it must be unique. minimum ➕200 addition.

@mdfaizanahmed786
Copy link
Contributor Author

@mdfaizanahmed786 To get "hactoberfest-accepted" label you need to add info and it must be unique. minimum ➕200 addition.

If you don't mind, can you describe in detail what info I need to add? Thank you for you time!

@shhossain
Copy link
Owner

@mdfaizanahmed786 See this issue

@mdfaizanahmed786
Copy link
Contributor Author

@mdfaizanahmed786 See this issue

Got it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shhossain shhossain shhossain requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdfaizanahmed786 @shhossain