Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized readme.md of data structures and added time complexity #31

Merged
merged 20 commits into from
Oct 2, 2022

Conversation

AnjumanHasan
Copy link
Contributor

All the information in the same readme.md file makes it difficult to read and lengthy as well.
I created a folder called blobaccess which will work in helping to guide from one readme to another hence make the project look clean.
I have also added time complexities table in array and linked list

@AnjumanHasan AnjumanHasan changed the title I am contributing to the Data Structures directory. Cleaned readme.md of data structures and added time complexity Oct 1, 2022
@AnjumanHasan AnjumanHasan changed the title Cleaned readme.md of data structures and added time complexity Organized readme.md of data structures and added time complexity Oct 1, 2022
Data Structures/readme.md Outdated Show resolved Hide resolved
Data Structures/readme.md Outdated Show resolved Hide resolved
Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each data structure should have a short description in Data Structure/readme.md file so you can just add time complexity to each data structure should do the job. And long descriptions like #30 in this PR should be added as extra.

@AnjumanHasan
Copy link
Contributor Author

Applied the requested changes.
Should I open a different PR for that?

@shhossain
Copy link
Owner

Applied the requested changes. Should I open a different PR for that?

No. Merging.

Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

@shhossain shhossain merged commit 4cfd905 into shhossain:main Oct 2, 2022
@AnjumanHasan
Copy link
Contributor Author

I will be adding extra content in array and linked list files for visualisation of data structures.
Is that okay?

@shhossain
Copy link
Owner

Sure why not. @AnjumanHasan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants