-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mysql json support (wip) #271
Open
kule
wants to merge
1
commit into
shioyama:master
Choose a base branch
from
kule:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# frozen-string-literal: true | ||
require "mobility/arel" | ||
|
||
module Mobility | ||
module Arel | ||
module Nodes | ||
%w[ | ||
JsonDashArrow | ||
JsonDashDoubleArrow | ||
].each do |name| | ||
const_set name, (Class.new(Binary) do | ||
include ::Arel::Expressions | ||
include ::Arel::Predications | ||
include ::Arel::OrderPredications | ||
include ::Arel::AliasPredication | ||
|
||
def lower | ||
super self | ||
end | ||
end) | ||
end | ||
|
||
class Json < JsonDashDoubleArrow; end | ||
|
||
class JsonContainer < Json | ||
def initialize column, locale, attr | ||
super(Arel::Nodes::JsonDashArrow.new(column, locale), attr) | ||
end | ||
end | ||
end | ||
|
||
module Visitors | ||
def visit_Mobility_Arel_Nodes_JsonDashArrow o, a | ||
json_infix o, a, '->' | ||
end | ||
|
||
def visit_Mobility_Arel_Nodes_JsonDashDoubleArrow o, a | ||
json_infix o, a, '->>' | ||
end | ||
|
||
private | ||
|
||
def json_infix o, a, opr | ||
visit(Nodes::Grouping.new(::Arel::Nodes::InfixOperation.new(opr, o.left, o.right)), a) | ||
end | ||
end | ||
|
||
::Arel::Visitors::MySQL.include Visitors | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that you're trying to support a container format for MySQL Json, but I think it will make things a bit complicated for this first PR. How about removing this and leaving it for another PR later?