Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Paketo full tag builder image #434

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Oct 7, 2020

This is a follow up from #406

I tested if the container images that we build with Paketo can be deployed
with the bionic stack via test branch.

Moving from builder:latest to builder:full means that we are gonna stop
running on top of a cflinuxfs3 stack in favor of a bionic stack.

Paketo community mentioned that the bionic stack have parity with cflinuxfs3,
therefore this is a safe change, plus the deployment validations I did.

@qu1queee qu1queee requested review from HeavyWombat and removed request for otaviof and gabemontero October 7, 2020 15:09
This is a follow up from shipwright-io#406

I tested if the container images that we build with Paketo can be deployed
with the bionic stack via [test branch](6ff4ece).

Moving from `builder:latest` to `builder:full` means that we are gonna stop
running on top of a cflinuxfs3 stack in favor of a bionic stack.

Paketo community mentioned that the bionic stack have parity with cflinuxfs3,
therefore this is a safe change, plus the deployment validations I did.
@qu1queee qu1queee force-pushed the qu1queee/paketo-bionic-stack branch from a42b45c to 4521bfa Compare October 8, 2020 13:55
@zhangtbj
Copy link
Contributor

zhangtbj commented Oct 9, 2020

Thanks for the verification!

Let us switch to use full image tag.

@xiujuan95 will continue communicating with Paketo community to see if they can switch latest image tag to full officially.

It doesn't make sense if they will not update full-cf stack but still using latest based on it, most of users will use latest directly.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangtbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit c035750 into shipwright-io:master Oct 9, 2020
@qu1queee qu1queee deleted the qu1queee/paketo-bionic-stack branch October 9, 2020 07:04
@xiujuan95
Copy link
Contributor

@zhangtbj @qu1queee Just for your info, community said they will switch latest to point to the full builder soon:https://paketobuildpacks.slack.com/archives/CULAS8ACD/p1602517320018900?thread_ts=1600670275.004100&cid=CULAS8ACD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants