From 640e2ac1ba348dfb8dc045055f26ce365c7d45d3 Mon Sep 17 00:00:00 2001
From: Sascha Schwarze <schwarzs@de.ibm.com>
Date: Sun, 17 Oct 2021 20:38:10 +0000
Subject: [PATCH] Make sure Dockerfile is not set to empty string

---
 pkg/shp/flags/build.go      | 3 +++
 pkg/shp/flags/build_test.go | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/pkg/shp/flags/build.go b/pkg/shp/flags/build.go
index 54f44735b..bca357e34 100644
--- a/pkg/shp/flags/build.go
+++ b/pkg/shp/flags/build.go
@@ -65,4 +65,7 @@ func SanitizeBuildSpec(b *buildv1alpha1.BuildSpec) {
 	if b.Timeout != nil && b.Timeout.Duration == 0 {
 		b.Timeout = nil
 	}
+	if b.Dockerfile != nil && *b.Dockerfile == "" {
+		b.Dockerfile = nil
+	}
 }
diff --git a/pkg/shp/flags/build_test.go b/pkg/shp/flags/build_test.go
index 37ee2a8e5..bfa78733f 100644
--- a/pkg/shp/flags/build_test.go
+++ b/pkg/shp/flags/build_test.go
@@ -127,6 +127,8 @@ func TestSanitizeBuildSpec(t *testing.T) {
 		},
 	}
 
+	emptyString := ""
+
 	testCases := []struct {
 		name string
 		in   buildv1alpha1.BuildSpec
@@ -161,6 +163,10 @@ func TestSanitizeBuildSpec(t *testing.T) {
 			Duration: time.Duration(0),
 		}},
 		out: buildv1alpha1.BuildSpec{Timeout: nil},
+	}, {
+		name: "should clean-up an empty Dockerfile",
+		in:   buildv1alpha1.BuildSpec{Dockerfile: &emptyString},
+		out:  buildv1alpha1.BuildSpec{Dockerfile: nil},
 	}}
 
 	for _, tt := range testCases {