From 63192287bcc3743cb3de8e46ee159a0b180862c3 Mon Sep 17 00:00:00 2001 From: John Joyce Date: Mon, 23 Aug 2021 20:19:04 -0700 Subject: [PATCH] fix(react): refactoring hasKeySchema computation (#3146) --- .../src/app/entity/dataset/profile/schema/Schema.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/datahub-web-react/src/app/entity/dataset/profile/schema/Schema.tsx b/datahub-web-react/src/app/entity/dataset/profile/schema/Schema.tsx index b50a8597a1c6fe..dd11594c424df8 100644 --- a/datahub-web-react/src/app/entity/dataset/profile/schema/Schema.tsx +++ b/datahub-web-react/src/app/entity/dataset/profile/schema/Schema.tsx @@ -63,10 +63,14 @@ export default function SchemaView({ fetchPolicy: 'no-cache', }); - const hasKeySchema = useMemo( - () => (schema?.fields?.findIndex((field) => field.fieldPath.indexOf(KEY_SCHEMA_PREFIX) > -1) || -1) !== -1, - [schema], - ); + const hasKeySchema = useMemo(() => { + const keySchemaIndex = schema?.fields?.findIndex((field) => field.fieldPath.indexOf(KEY_SCHEMA_PREFIX) > -1); + if (keySchemaIndex !== undefined && keySchemaIndex > -1) { + // We found a key schema. + return true; + } + return false; + }, [schema]); const [showKeySchema, setShowKeySchema] = useState(false);