Skip to content

Commit

Permalink
Styles fixes (#2238)
Browse files Browse the repository at this point in the history
* fix invalid rule

* fixes #2107
  • Loading branch information
claviska authored Oct 28, 2024
1 parent fa71602 commit 73c469f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
1 change: 1 addition & 0 deletions docs/pages/resources/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
- Added support for <kbd>Enter</kbd> to `<sl-split-panel>` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/) [#2234]
- Fixed a bug in `<sl-carousel>` that caused the navigation icons to be reversed
- Fixed a bug in `<sl-select>` that prevented label changes in `<sl-option>` from updating the controller [#1971]
- Fixed a bug in `<sl-textarea>` that caused a console warning in Firefox when typing [#2107]
- Improved performance of `<sl-range>` by skipping positioning logic when tooltip isn't shown [#2064]

## 2.18.0
Expand Down
5 changes: 1 addition & 4 deletions src/components/tab/tab.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,8 @@ export default css`
outline: transparent;
}
:host(:focus-visible):not([disabled]) {
color: var(--sl-color-primary-600);
}
:host(:focus-visible) {
color: var(--sl-color-primary-600);
outline: var(--sl-focus-ring);
outline-offset: calc(-1 * var(--sl-focus-ring-width) - var(--sl-focus-ring-offset));
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/textarea/textarea.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export default class SlTextarea extends ShoelaceElement implements ShoelaceFormC
this.input.style.height = 'auto';
this.input.style.height = `${this.input.scrollHeight}px`;
} else {
(this.input.style.height as string | undefined) = undefined;
this.input.style.height = '';
}
}

Expand Down

0 comments on commit 73c469f

Please sign in to comment.