Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] base_url: Migration to 13.0 #478

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Oct 29, 2019

No description provided.

@lmignon lmignon added the 13.0 label Oct 29, 2019
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (13.0@b13b7a7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             13.0     #478   +/-   ##
=======================================
  Coverage        ?   82.45%           
=======================================
  Files           ?        2           
  Lines           ?      114           
  Branches        ?        0           
=======================================
  Hits            ?       94           
  Misses          ?       20           
  Partials        ?        0
Impacted Files Coverage Δ
base_url/models/url_url.py 91.66% <100%> (ø)
base_url/models/abstract_url.py 80% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13b7a7...1fda49a. Read the comment docs.

@lmignon
Copy link
Collaborator Author

lmignon commented Oct 29, 2019

/ocabot merge

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-478-by-lmignon-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 29, 2019
Signed-off-by lmignon
@shopinvader-git-bot
Copy link

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-478-by-lmignon-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@lmignon
Copy link
Collaborator Author

lmignon commented Oct 29, 2019

/ocabot merge

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-478-by-lmignon-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 29, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit 1fda49a into shopinvader:13.0 Oct 29, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 396d28e. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 13.0-mig-base-url branch October 29, 2019 16:32
@rousseldenis rousseldenis mentioned this pull request May 26, 2020
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants