Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] shopinvader: Migration to 13.0 #503

Merged
merged 6 commits into from
Jan 2, 2020
Merged

[13.0] shopinvader: Migration to 13.0 #503

merged 6 commits into from
Jan 2, 2020

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Nov 11, 2019 •
edited
Loading

Nice to have:

  • create methods should be rewritten to support multi
  • The logic to bind / unbind products and categories should be implemented as component in place of wizard. Previously it was possible to work with in-memory record of the wizard to call the same logic from within odoo. In Odoo 13 it's no more the case. That means that to rebind thousand of records we must create thousand of rows into the database to reuse the logic provided by the wizard.
  • On product.category the name is no more translatable in V13. This functionality has been restored into shopinvader. This should be moved into a dedicated addon

@lmignon lmignon added the WIP label Nov 11, 2019
@codecov-io
Copy link

codecov-io commented Nov 11, 2019 •
edited
Loading

Codecov Report

Merging #503 into 13.0 will increase coverage by 5.96%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             13.0     #503      +/-   ##
==========================================
+ Coverage   82.45%   88.42%   +5.96%     
==========================================
  Files           2       41      +39     
  Lines         114     1952    +1838     
==========================================
+ Hits           94     1726    +1632     
- Misses         20      226     +206
Impacted Files Coverage Δ
shopinvader/models/sale.py 92.5% <ø> (ø)
shopinvader/models/product_product.py 75% <ø> (ø)
shopinvader/wizards/shopinvader_partner_binding.py 92.59% <ø> (ø)
shopinvader/models/shopinvader_backend.py 86.8% <ø> (ø)
shopinvader/models/seo_title_mixin.py 87.5% <ø> (ø)
shopinvader/services/cart.py 87.43% <ø> (ø)
...r/wizards/shopinvader_category_unbinding_wizard.py 93.75% <100%> (ø)
...er/wizards/shopinvader_variant_unbinding_wizard.py 94.44% <100%> (ø)
shopinvader/models/product_template.py 81.81% <100%> (ø)
shopinvader/models/account_move.py 100% <100%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebea784...4eb7943. Read the comment docs.

@lmignon lmignon force-pushed the 13.0-mig-shopinvader branch 2 times, most recently from abfdef3 to 88baabf Compare November 11, 2019 11:01
@lmignon lmignon added the 13.0 label Nov 11, 2019
@lmignon lmignon mentioned this pull request Nov 13, 2019
Merged
1 task
@lmignon lmignon removed the WIP label Nov 13, 2019
This was referenced Nov 13, 2019
Merged
Closed
@rousseldenis rousseldenis added this to the 13.0 milestone Nov 28, 2019
rousseldenis
rousseldenis approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Contributor

It seems that tests are failing due to odoo/odoo#41791

Don't know why yet.

@rousseldenis
[13.0][FIX] shopinvader: Fix multi company tests
d9c6fc0 
Since odoo/odoo@af50c69
it's dangerous to write company_id on user as it will be kept in cache.

To simulate company change in tests, better to add 'allowed_company_ids'
in context
@rousseldenis
[13.0] shopinvader: Add ROADMAP features
4eb7943
@rousseldenis
Copy link
Contributor

I've put missing technical features in ROADMAP

@rousseldenis
Copy link
Contributor

/ocabot merge

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-503-by-rousseldenis-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jan 2, 2020
Merge PR #503 into 13.0
5f1c087 
Signed-off-by rousseldenis
@shopinvader-git-bot shopinvader-git-bot merged commit 4eb7943 into shopinvader:13.0 Jan 2, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 843ba72. Thanks a lot for contributing to shopinvader. ❤️

@rousseldenis rousseldenis mentioned this pull request Jan 2, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
13.0 merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lmignon @codecov-io @rousseldenis @shopinvader-git-bot