Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] shopinvader_locomotive: Migration to 13.0 #508

Merged

Conversation

@lmignon lmignon added the 13.0 label Nov 13, 2019
@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #508 into 13.0 will increase coverage by 0.74%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            13.0     #508      +/-   ##
=========================================
+ Coverage   88.5%   89.25%   +0.74%     
=========================================
  Files         51       74      +23     
  Lines       2106     2523     +417     
=========================================
+ Hits        1864     2252     +388     
- Misses       242      271      +29
Impacted Files Coverage Δ
shopinvader_locomotive/models/res_partner.py 100% <100%> (ø)
...hopinvader_locomotive/models/locomotive_binding.py 100% <100%> (ø)
shopinvader_locomotive/component/mapper.py 100% <0%> (ø)
shopinvader_image/services/abstract_sale.py 100% <0%> (ø)
...opinvader_image/models/shopinvader_image_resize.py 81.81% <0%> (ø)
shopinvader_locomotive/component/core.py 100% <0%> (ø)
shopinvader_locomotive/services/customer.py 71.42% <0%> (ø)
...opinvader_locomotive/models/shopinvader_partner.py 100% <0%> (ø)
shopinvader_image/models/shopinvader_variant.py 100% <0%> (ø)
...hopinvader_image/models/shopinvader_image_mixin.py 100% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe80f7...f7d760d. Read the comment docs.

@simahawk
Copy link
Contributor

simahawk commented Jan 7, 2020

@lmignon requirements.txt update missing

ModuleNotFoundError: No module named 'locomotivecms'

@lmignon
Copy link
Collaborator Author

lmignon commented Jan 7, 2020

/ocabot merge

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-508-by-lmignon-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jan 7, 2020
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit f7d760d into shopinvader:13.0 Jan 7, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at d37c560. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 13.0-mig-shopinvader-locomotive branch January 7, 2020 12:57
@rousseldenis rousseldenis mentioned this pull request May 26, 2020
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants