Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] shopinvader_elasticsearch #537

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Dec 19, 2019

@rousseldenis rousseldenis requested review from lmignon and simahawk and removed request for lmignon December 19, 2019 11:23
@rousseldenis rousseldenis added this to the 13.0 milestone Dec 19, 2019
@rousseldenis rousseldenis force-pushed the 13.0-mig-shopinvader_elasticsearch-dro branch from 05adc6d to 70231c3 Compare January 2, 2020 13:56
@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #537 into 13.0 will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             13.0   #537      +/-   ##
========================================
+ Coverage   88.26%    89%   +0.74%     
========================================
  Files          49     60      +11     
  Lines        2062   2211     +149     
========================================
+ Hits         1820   1968     +148     
- Misses        242    243       +1
Impacted Files Coverage Δ
shopinvader_image/hooks.py 100% <0%> (ø)
shopinvader_image/models/shopinvader_backend.py 100% <0%> (ø)
...opinvader_assortment/models/shopinvader_backend.py 100% <0%> (ø)
shopinvader_image/services/abstract_sale.py 100% <0%> (ø)
...opinvader_image/models/shopinvader_image_resize.py 81.81% <0%> (ø)
shopinvader_image/models/shopinvader_category.py 100% <0%> (ø)
shopinvader_assortment/models/se_index.py 71.42% <0%> (ø)
...hopinvader_image/models/shopinvader_image_mixin.py 100% <0%> (ø)
shopinvader_image/models/shopinvader_variant.py 100% <0%> (ø)
...nvader_elasticsearch/models/shopinvader_product.py 100% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429ac18...70231c3. Read the comment docs.

@rousseldenis rousseldenis mentioned this pull request Jan 2, 2020
38 tasks
@simahawk simahawk added the 13.0 label Jan 7, 2020
@simahawk
Copy link
Contributor

simahawk commented Jan 7, 2020

@rousseldenis looks good but build is red:

module shopinvader_elasticsearch: Unmet dependencies: connector_elasticsearch

@rousseldenis
Copy link
Contributor Author

@rousseldenis looks good but build is red:

module shopinvader_elasticsearch: Unmet dependencies: connector_elasticsearch

OCA/search-engine#43

Reveiws are welcome ! 😃

@simahawk
Copy link
Contributor

simahawk commented Jan 7, 2020

ìt's merging 😉

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

simahawk commented Jan 7, 2020

/ocabot merge

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-537-by-simahawk-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jan 7, 2020
Signed-off-by simahawk
@shopinvader-git-bot shopinvader-git-bot merged commit 70231c3 into shopinvader:13.0 Jan 7, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 2913423. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 13.0-mig-shopinvader_elasticsearch-dro branch January 7, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants