-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] shopinvader_import_image: Migration to 13.0 #554
[MIG] shopinvader_import_image: Migration to 13.0 #554
Conversation
55d5cb8
to
712ecd8
Compare
Codecov Report
@@ Coverage Diff @@
## 13.0 #554 +/- ##
=========================================
- Coverage 89.95% 89.9% -0.06%
=========================================
Files 87 88 +1
Lines 2926 3050 +124
=========================================
+ Hits 2632 2742 +110
- Misses 294 308 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
I merge as it is since it works. I add some improvements in another PR |
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-554-by-simahawk-bump-no. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
hmm I cancelled the build. I just realized I messed up some commits 😭 |
712ecd8
to
343c759
Compare
343c759
to
0a9317d
Compare
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at dbee073. Thanks a lot for contributing to shopinvader. ❤️ |
Depends on OCA/storage#34 + #552
Migrated and refactored.
I'll add support to read from external storage via storage_backend.