Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] shopinvader_import_image: Migration to 13.0 #554

Merged

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Jan 10, 2020

Depends on OCA/storage#34 + #552

Migrated and refactored.
I'll add support to read from external storage via storage_backend.

@simahawk simahawk force-pushed the 13-shopinvader_import_image branch 2 times, most recently from 55d5cb8 to 712ecd8 Compare January 16, 2020 10:45
@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #554 into 13.0 will decrease coverage by 0.05%.
The diff coverage is 88.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##             13.0    #554      +/-   ##
=========================================
- Coverage   89.95%   89.9%   -0.06%     
=========================================
  Files          87      88       +1     
  Lines        2926    3050     +124     
=========================================
+ Hits         2632    2742     +110     
- Misses        294     308      +14
Impacted Files Coverage Δ
shopinvader_import_image/wizards/import_image.py 88.7% <88.7%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74e401...b37b112. Read the comment docs.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@simahawk simahawk removed the WIP label Jan 17, 2020
@simahawk
Copy link
Contributor Author

I merge as it is since it works. I add some improvements in another PR

@simahawk
Copy link
Contributor Author

/ocabot merge

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-554-by-simahawk-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jan 17, 2020
Signed-off-by simahawk
@shopinvader-git-bot
Copy link

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-554-by-simahawk-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk
Copy link
Contributor Author

hmm I cancelled the build. I just realized I messed up some commits 😭

@simahawk
Copy link
Contributor Author

simahawk commented Feb 3, 2020

/ocabot merge

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-554-by-simahawk-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Feb 3, 2020
Signed-off-by simahawk
@shopinvader-git-bot shopinvader-git-bot merged commit b37b112 into shopinvader:13.0 Feb 3, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at dbee073. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants