Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding super dash counter example #10

Closed
wants to merge 6 commits into from

Conversation

erickzanardo
Copy link
Contributor

Description

A simple sample using Flame.

It implements a classic counter, but gamified. Originally the character does not have enough power to jump and reach the controllers blocks, which we can fix with a patch.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 🧪 Tests
  • 📝 Documentation
  • 🗑️ Chore

@@ -0,0 +1,4 @@
include: package:flutter_lints/flutter.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also might want to use very_good_analysis to be consistent with the other shorebird projects 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I checked on the flavors one and I saw just the flutter lints, so I thought that was the standard for samples. I will def change

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great but this might make more sense under your own personal GitHub since this repo has historically been for source code used in the shorebird docs guides 🤷

wdyt @bryanoltman @eseidel?

@eseidel
Copy link
Contributor

eseidel commented Apr 17, 2024

I don't have a strong opinion one way or the other about this specific example. I would say if we have guidelines for what should/shouldn't be in samples we should make those clear in the README.md :) e.g. We likely aren't accepting feature patches to samples in general, but would accept bug fixes. If samples are unused by our team we will delete them.

Co-authored-by: Felix Angelov <felix@shorebird.dev>
@erickzanardo
Copy link
Contributor Author

Moved the code to https://github.com/erickzanardo/super_dash_counter

Closing this.

@erickzanardo erickzanardo deleted the feat/super_dash_counter branch April 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants