Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): default to current app in shorebird preview #1530

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

When running shorebird preview in a shorebird app project, default to that project.

Fixes #1115

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b2e905) 100.00% compared to head (9c512ed) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines         4761      4763    +2     
=========================================
+ Hits          4761      4763    +2     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit dd0ac29 into main Nov 22, 2023
8 checks passed
@bryanoltman bryanoltman deleted the bo/preview-default-current-app branch November 22, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: shorebird preview could default to the current app?
2 participants