Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): use release mach-o artifact instead of patch mach-o artifact as base for linking #1546

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

shorebird patch ios-alpha --use-linker is currently linking an AOT snapshot produced from a patch build against the patch mach-o binary. This change fixes this, to make shorebird patch ios-alpha --use-linker download the release artifact and use that as a base for linking.

An example invocation of the link command with this change:

dart /Users/bryanoltman/shorebirdtech/dart-sdk/sdk/pkg/aot_tools/bin/aot_tools.dart link --debug --base=/var/folders/vn/04w25hyn3cg8436mp3qhhv8m0000gn/T/1ZzqC0/Products/Applications/Runner.app/Frameworks/App.framework/App --patch=/Users/bryanoltman/Documents/sandbox/new_app/build/out.aot --analyze-snapshot=/Users/bryanoltman/shorebirdtech/engine/src/out/ios_release/clang_x64/analyze_snapshot_arm64

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fa62ba) 100.00% compared to head (aabe321) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1546   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines         4760      4766    +6     
=========================================
+ Hits          4760      4766    +6     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from bo/diff-checker-download to main November 29, 2023 21:51
@bryanoltman bryanoltman merged commit bce214e into main Nov 29, 2023
8 checks passed
@bryanoltman bryanoltman deleted the bo/ios-patch-link branch November 29, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants