fix(shorebird_cli): support --split-debug-info
#2570
Merged
+461
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Would you mind updating the description to explain what is changing? |
eseidel
reviewed
Oct 23, 2024
packages/shorebird_cli/lib/src/commands/patch/ios_framework_patcher.dart
Outdated
Show resolved
Hide resolved
eseidel
reviewed
Oct 23, 2024
packages/shorebird_cli/lib/src/commands/patch/ios_framework_patcher.dart
Outdated
Show resolved
Hide resolved
eseidel
reviewed
Oct 23, 2024
eseidel
approved these changes
Oct 23, 2024
Yup sorry about that, done 👍 |
bryanoltman
reviewed
Oct 23, 2024
packages/shorebird_cli/lib/src/commands/patch/ios_framework_patcher.dart
Outdated
Show resolved
Hide resolved
bryanoltman
reviewed
Oct 23, 2024
packages/shorebird_cli/lib/src/commands/patch/ios_framework_patcher.dart
Outdated
Show resolved
Hide resolved
bryanoltman
reviewed
Oct 23, 2024
bryanoltman
reviewed
Oct 23, 2024
bryanoltman
reviewed
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--split-debug-info(closes fix: shorebird patch iOSFailed to link AOT files: Exception: Failed to link:#2480)--split-debug-infoflag to theflutter_tool, the resultinggen_snapshotexecution includes additional flags ('--dwarf-stack-traces', '--resolve-dwarf-paths', '--save-debugging-info') previously, we were proxying this flag when building the release but when building the optimized aot snapshot (as part of the linking step) we were not supplying the additional flags which would result in different vm sections of the generated snapshot.Type of Change