-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to work with latest discord api and other misc fixes #11
Conversation
Nice! I am surprised the core of this crate still works after 2 years of not being developed (something with getting into university and getting a job, no time for hobby projects) . I'll look at your PR tonight. |
Yeah it is very robust, and tbh I was simply too lazy to reimplement discord interactions 😅 And dw I know the grind.. To be honest I did not expect to get a response at all, so I'm positively surprised ^^ |
PR looks good. We do have to update the examples but that seems like a quick fix. I'll check if I can fix that before merging. |
Nice! I was more or less referring to the current tests though, they fail atm. |
Yeah I know. as stated in the original message I didn't touch those at all, so ofc they would break 😅 |
The examples build fail somehow in the CI but I can't reproduce the errors on my own machine. They run and compile just fine. Is that the same for you? |
You know what f*ck it. I am merging this and we'll see if it breaks after merging. |
no they very much fail to compile for me (as would be expected) |
0.3.0
Important
Note that this PR does NOT address updating the test or examples files