Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to work with latest discord api and other misc fixes #11

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

UpcraftLP
Copy link
Contributor

  • updated dependencies
  • updated repository URL in metadata
  • added missing ApplicationCommandOptionType options
  • added resolved data to interaction context (needed for ex. file attachment arguments)
  • made discord API BASE_URL public so it can be used outside the crate
  • made it so people can run their own independent web server and only redirect specific paths to this crate's interaction handler, instead of being forced to use this crate's default implementation
  • misc fixes
  • bump version to 0.3.0

Important

Note that this PR does NOT address updating the test or examples files

@showengineer
Copy link
Owner

Nice! I am surprised the core of this crate still works after 2 years of not being developed (something with getting into university and getting a job, no time for hobby projects) . I'll look at your PR tonight.

@UpcraftLP
Copy link
Contributor Author

Yeah it is very robust, and tbh I was simply too lazy to reimplement discord interactions 😅

And dw I know the grind.. To be honest I did not expect to get a response at all, so I'm positively surprised ^^

@showengineer
Copy link
Owner

PR looks good. We do have to update the examples but that seems like a quick fix. I'll check if I can fix that before merging.

@UpcraftLP
Copy link
Contributor Author

fwiw

  • here is also how I'm using the crate with a separate web server
  • and here is how I'm handling attachments.

Those feel like they could use additional examples/documentation for new users ^^

@showengineer
Copy link
Owner

Nice! I was more or less referring to the current tests though, they fail atm.

@UpcraftLP
Copy link
Contributor Author

Yeah I know. as stated in the original message I didn't touch those at all, so ofc they would break 😅

@showengineer showengineer self-assigned this Jan 8, 2024
@showengineer showengineer added the breaking-change This pull request contains breaking changes label Jan 8, 2024
@showengineer
Copy link
Owner

showengineer commented Jan 9, 2024

The examples build fail somehow in the CI but I can't reproduce the errors on my own machine. They run and compile just fine. Is that the same for you?

@showengineer
Copy link
Owner

You know what f*ck it. I am merging this and we'll see if it breaks after merging.

@showengineer showengineer merged commit 32281f8 into showengineer:main Jan 9, 2024
4 of 6 checks passed
@UpcraftLP
Copy link
Contributor Author

The examples build fail somehow in the CI but I can't reproduce the errors on my own machine. They run and compile just fine. Is that the same for you?

no they very much fail to compile for me (as would be expected)

@UpcraftLP UpcraftLP deleted the update branch October 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants