Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy rails app to make tests run #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ritxi
Copy link

@ritxi ritxi commented Sep 6, 2019

Hi, I've just fixed test suite to run all tests without missing dependendies errors

@janko
Copy link
Member

janko commented Sep 12, 2019

Thanks for the pull request. Unfortunately, these changes tie shrine-reform to Rails (and ActiveModel validations), which is not ideal for people using Reform outside of Rails (and with dry-validation). Though shrine-reform doesn't seem to actually work with dry-validation anyway (see #2) 🤷‍♂

Note that @apotonick is working on Reform 3.0, which will be a rewrite of the existing API. But that will perhaps take time, so maybe it makes sense to make shrine-reform work with Reform 2.x. I've been holding off on updating compatibility until Reform 2.3 is released, however, it seems that will be delayed indefinitely in favour of version 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants