Add master server ID to BinaryLogClient. #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BinaryLogClientIntegrationTest` class did not clean-up after itself: it tried to create the `test_metameta` table unconditionally. This test would then fail if the tests were run twice. I _believe_ that this change keeps the original intent intact.
When the `BinaryLogClient` connects to a MySQL server, it's not currently possible to identify to which server it has connected. When connecting to a pool of replicas through a load balancer, for example, a reconnect may mean the `BinaryLogClient` is connected to a different MySQL server. When using binary log file positions instead of GTIDs, this can be critical: attempting to resume from the same binary log positions on a different MySQL server may result in missed or duplicated events. Similarly, not resuming from the same binary log positions when reconnecting to the same server is wasteful and may result in longer recovery/catch-up times. This change adds the ability to get the equivalent of `MASTER_SERVER_ID` from the `BinaryLogClient`. This can then be inspected within each of the `LifecycleListener` events.
|
merged into https://github.com/osheroff/mysql-binlog-connector-java, will release in fork |
|
@osheroff You are going to fork your fork permenent (if shyiko is not active here)?? |
|
@bluebike yeah if shyiko doesn't come back I'll maintain my fork. Better mariaDB would be a welcome PR, but I don't have a production installation so I'd just be accepting contributions and such. My main goal is to keep this package maintained so that I can make modifications for Maxwell's needs... I've opened up issues on my fork. |
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
BinaryLogClientconnects to a MySQL server, it's notcurrently possible to identify to which server it has connected. When
connecting to a pool of replicas through a load balancer, for example, a
reconnect may mean the
BinaryLogClientis connected to a differentMySQL server.
When using binary log file positions instead of GTIDs, this can be
critical: attempting to resume from the same binary log positions on a
different MySQL server may result in missed or duplicated events.
Similarly, not resuming from the same binary log positions when
reconnecting to the same server is wasteful and may result in longer
recovery/catch-up times.
This change adds the ability to get the equivalent of
MASTER_SERVER_IDfrom the
BinaryLogClient. This can then be inspected within each ofthe
LifecycleListenerevents.This pull request also includes a separate commit to fix an unrelated test.