chore: update core tsconfig based on @tsconfig/node16 (aws#6038)

siddsriv · May 8, 2024 · a8e9ab0 · a8e9ab0
1 parent b0e4b2f
commit a8e9ab0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 26 deletions.
diff --git a/packages/util-dynamodb/src/convertToAttr.spec.ts b/packages/util-dynamodb/src/convertToAttr.spec.ts
@@ -99,11 +99,8 @@ describe("convertToAttr", () => {
     [true, false].forEach((convertClassInstanceToMap) => {
       const maxSafe = BigInt(Number.MAX_SAFE_INTEGER);
       [
-        // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
         1n,
-        // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
         maxSafe * 2n,
-        // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
         maxSafe * -2n,
         BigInt(Number.MAX_VALUE),
         BigInt("0x1fffffffffffff"),
@@ -120,11 +117,8 @@ describe("convertToAttr", () => {
     [true, false].forEach((convertClassInstanceToMap) => {
       const maxSafe = BigInt(Number.MAX_SAFE_INTEGER);
       [
-        // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
         1n,
-        // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
         maxSafe * 2n,
-        // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
         maxSafe * -2n,
         BigInt(Number.MAX_VALUE),
         BigInt("0x1fffffffffffff"),
@@ -263,7 +257,6 @@ describe("convertToAttr", () => {
     });
 
     it("bigint set", () => {
-      // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
       const bigNum = BigInt(Number.MAX_SAFE_INTEGER) + 2n;
       const set = new Set([bigNum, -bigNum]);
       expect(convertToAttr(set)).toEqual({ NS: Array.from(set).map((num) => num.toString()) });

diff --git a/packages/util-dynamodb/src/convertToAttrToNative.spec.ts b/packages/util-dynamodb/src/convertToAttrToNative.spec.ts
@@ -45,9 +45,7 @@ describe("convertToAttrToNative", () => {
   describe("bigint", () => {
     const maxSafe = BigInt(Number.MAX_SAFE_INTEGER);
     [
-      // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
       maxSafe * 2n,
-      // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
       maxSafe * -2n,
       BigInt(Number.MAX_VALUE),
       BigInt("0x1fffffffffffffff"),
@@ -147,7 +145,6 @@ describe("convertToAttrToNative", () => {
     });
 
     describe("bigint set", () => {
-      // @ts-expect-error BigInt literals are not available when targeting lower than ES2020.
       const bigNum = BigInt(Number.MAX_SAFE_INTEGER) + 2n;
       const set = new Set([bigNum, -bigNum]);
 

diff --git a/tsconfig.cjs.json b/tsconfig.cjs.json
@@ -1,10 +1,3 @@
 {
-  "extends": "./tsconfig.json",
-  "compilerOptions": {
-    "importHelpers": true,
-    "module": "commonjs",
-    "noEmitHelpers": false,
-    "target": "ES2018",
-    "strict": true
-  }
+  "extends": "./tsconfig.json"
 }
diff --git a/tsconfig.es.json b/tsconfig.es.json
@@ -1,10 +1,7 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "importHelpers": true,
-    "module": "esnext",
-    "noEmitHelpers": false,
-    "target": "ES2020",
-    "strict": true
+    "lib": ["dom"],
+    "module": "esnext"
   }
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,12 +1,13 @@
 {
+  "extends": "@tsconfig/node16/tsconfig.json",
   "compilerOptions": {
     "baseUrl": ".",
     "downlevelIteration": true,
-    "esModuleInterop": true,
     "incremental": true,
-    "lib": ["es2015", "dom"],
+    "importHelpers": true,
     "module": "commonjs",
     "moduleResolution": "node",
+    "noEmitHelpers": false,
     "noFallthroughCasesInSwitch": true,
     "paths": {
       "@aws-sdk/*": ["packages/*/"],
@@ -17,7 +18,6 @@
     "preserveConstEnums": true,
     "removeComments": true,
     "resolveJsonModule": true,
-    "target": "es5",
     "useUnknownInCatchVariables": false,
     "experimentalDecorators": true,
     "jsx": "react",