feat: add persistence support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkuozdemir
approved these changes
May 16, 2024
frezbo
approved these changes
May 16, 2024
Add support to persist and load buffer from disk. Co-authored-by: Utku Ozdemir <utku.ozdemir@siderolabs.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
|
/m |
utkuozdemir
added a commit
to utkuozdemir/sidero-omni
that referenced
this pull request
Jun 10, 2024
Switch from the old machine log storage approach to using the new persistence feature in the go-circular: siderolabs/go-circular#4 Implement a migration code to migrate from old format to the new format when a machine log buffer is initialized. Move some hardcoded log buffer settings into config (CLI args). Use a default jitter of 0.1 (10+-1 minutes). Rework the CLI arg names to be consistent. Closes siderolabs#118. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
added a commit
to utkuozdemir/sidero-omni
that referenced
this pull request
Jun 10, 2024
Switch from the old machine log storage approach to using the new persistence feature in the go-circular: siderolabs/go-circular#4 Implement a migration code to migrate from old format to the new format when a machine log buffer is initialized. Move some hardcoded log buffer settings into config (CLI args). Use a default jitter of 0.1 (10+-1 minutes). Rework the CLI arg names to be consistent. Closes siderolabs#118. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
added a commit
to utkuozdemir/sidero-omni
that referenced
this pull request
Jun 10, 2024
Switch from the old machine log storage approach to using the new persistence feature in the go-circular: siderolabs/go-circular#4 Implement a migration code to migrate from old format to the new format when a machine log buffer is initialized. Move some hardcoded log buffer settings into config (CLI args). Use a default jitter of 0.1 (10+-1 minutes). Rework the CLI arg names to be consistent. Closes siderolabs#118. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to persist and load buffer from disk.