Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move from Codec to CodecV2 #681

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore: move from Codec to CodecV2 #681

merged 1 commit into from
Oct 15, 2024

Conversation

DmitriyMV
Copy link
Member

This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

@Unix4ever
Copy link
Member

Unix4ever commented Oct 10, 2024 •
edited
Loading

2024-10-10T20:21:23.751Z ERROR task/task.go:82 restarting task {"component": "omni_runtime", "controller": "MachineStatusController", "namespace": "default", "type": "Machines.omni.sidero.dev", "id": "00000703-c798-4da7-a410-f09abb48c8d8", "job": "reconcile", "task": "00000703-c798-4da7-a410-f09abb48c8d8", "interval": "35.826678552s", "error": "failed to list resource definitions: rpc error: code = Unavailable desc = connection error: desc = \"transport: authentication handshake failed: credentials: cannot check peer: missing selected ALPN property\""}

It looks like something doesn't play well with the emulator...
Talos might have the same issue I suppose.

@Unix4ever Unix4ever added the integration/e2e Triggers all e2e tests for Omni label Oct 10, 2024
@DmitriyMV
Copy link
Member Author

DmitriyMV commented Oct 10, 2024 •
edited
Loading

It looks like something doesn't play well with the emulator...

This should be fixed in siderolabs/crypto#34 but lets see (I updated the branch)...

@DmitriyMV DmitriyMV force-pushed the codec branch 8 times, most recently from a3bf2ea to 3f38d89 Compare October 12, 2024 18:38
@DmitriyMV
chore: move from Codec to CodecV2
1544b9c 
This should be protocol backward compatible change (and breaking change in the source code) which should speed-up the process of gRPC
data encoding / decoding. Also unify our CodecV2 usage.

For siderolabs/talos#9404

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV
Copy link
Member Author

/m

@talos-bot talos-bot merged commit 1544b9c into siderolabs:main Oct 15, 2024
20 checks passed
@DmitriyMV DmitriyMV deleted the codec branch October 15, 2024 19:16
This was linked to issues Oct 16, 2024
Find a way to use grpc-go >= 1.67.0 with ALPN disabled siderolabs/talos#9463
Closed
unifying protobuf/grpc codec implementation siderolabs/talos#9404
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unix4ever Unix4ever Unix4ever approved these changes

Assignees
No one assigned
Labels
integration/e2e Triggers all e2e tests for Omni
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find a way to use grpc-go >= 1.67.0 with ALPN disabled unifying protobuf/grpc codec implementation
3 participants
@DmitriyMV @Unix4ever @talos-bot