Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop the LVM2 udev lvm rule #1042

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: drop the LVM2 udev lvm rule #1042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lvm2/pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ steps:
install:
- |
make DESTDIR=/rootfs install

# LVM activation is handled by Talos itself
rm -f /rootfs/usr/lib/udev/rules.d/69-dm-lvm.rules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't https://github.com/lvmteam/lvm2/blob/main/udev/95-dm-notify.rules.in also unnecessary? We seem not to have dmsetup in our rootfs if I'm not mistaken

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, but I don't want to make bigger changes, as this is going to be backported to 1.8 - so the minimal changes required

finalize:
- from: /rootfs
to: /