feat: enable CONFIG_X86_AMD_PSTATE #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroy
force-pushed
the
amd-pstate
branch
2 times, most recently
from
ca4cb9d to
5b5fdd5
Compare
frezbo
reviewed
Jun 24, 2024
| @@ -635,7 +635,8 @@ CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y | |||
| # | |||
| CONFIG_X86_INTEL_PSTATE=y | |||
| # CONFIG_X86_PCC_CPUFREQ is not set | |||
| # CONFIG_X86_AMD_PSTATE is not set | |||
| CONFIG_X86_AMD_PSTATE=y | |||
| CONFIG_X86_AMD_PSTATE_DEFAULT_MODE=3 | |||
There was a problem hiding this comment.
not sure if we should set this to active or passive?
There was a problem hiding this comment.
CONFIG_X86_AMD_PSTATE_DEFAULT_MODE=3 (passive) is the default because it most closely matches the performance of acpi-cpufreq, which is used if amd-pstate is disabled. It feels appropriate to keep that as the default and require the user to select active or guided (e.g. amd-pstate-epp) and configure it.
smira
approved these changes
Jun 28, 2024
|
Thanks for the approval. I rebased which broke the signature, sorry! I think your process is you re-commit, signing with a trusted key, so I should have left it alone. |
DmitriyMV
force-pushed
the
amd-pstate
branch
2 times, most recently
from
589f2ce to
2e92ea1
Compare
|
@jfroy no worries. Rebased and signed using my key. Will merge when PR is done. |
|
/ok-to-test |
fixes siderolabs#978 Signed-off-by: Jean-Francois Roy <jf@devklog.net> Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #978