Skip to content

Commit

Permalink
docs: add warning about NVMe bus path bug
Browse files Browse the repository at this point in the history
Document NVMe bus path.

Signed-off-by: solidDoWant <fred.heinecke@yahoo.com>
Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
  • Loading branch information
solidDoWant authored and smira committed Oct 31, 2024
1 parent 3e16ab1 commit d8b6521
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
6 changes: 3 additions & 3 deletions pkg/machinery/config/schemas/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2245,9 +2245,9 @@
"busPath": {
"type": "string",
"title": "busPath",
"description": "Disk bus path.\n",
"markdownDescription": "Disk bus path.",
"x-intellij-html-description": "\u003cp\u003eDisk bus path.\u003c/p\u003e\n"
"description": "Disk bus path.\nWarning: This requires special configuration for NVMe drives. For details, see https://github.com/siderolabs/go-blockdevice/issues/114.\n",
"markdownDescription": "Disk bus path.\nWarning: This requires special configuration for NVMe drives. For details, see https://github.com/siderolabs/go-blockdevice/issues/114.",
"x-intellij-html-description": "\u003cp\u003eDisk bus path.\nWarning: This requires special configuration for NVMe drives. For details, see \u003ca href=\"https://github.com/siderolabs/go-blockdevice/issues/114\" target=\"_blank\"\u003ehttps://github.com/siderolabs/go-blockdevice/issues/114\u003c/a\u003e.\u003c/p\u003e\n"
}
},
"additionalProperties": false,
Expand Down
4 changes: 3 additions & 1 deletion pkg/machinery/config/types/v1alpha1/v1alpha1_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,9 @@ type InstallDiskSelector struct {
// - nvme
// - sd
Type InstallDiskType `yaml:"type,omitempty"`
// description: Disk bus path.
// description: |
// Disk bus path.
// Warning: This requires special configuration for NVMe drives. For details, see https://github.com/siderolabs/go-blockdevice/issues/114.
// examples:
// - value: '"/pci0000:00/0000:00:17.0/ata1/host0/target0:0:0/0:0:0:0"'
// - value: '"/pci0000:00/*"'
Expand Down
2 changes: 1 addition & 1 deletion pkg/machinery/config/types/v1alpha1/v1alpha1_types_doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -1976,7 +1976,7 @@ size: <= 2TB
|`uuid` |string |Disk UUID `/sys/block/<dev>/uuid`. | |
|`wwid` |string |Disk WWID `/sys/block/<dev>/wwid`. | |
|`type` |InstallDiskType |Disk Type. |`ssd`<br />`hdd`<br />`nvme`<br />`sd`<br /> |
|`busPath` |string |Disk bus path. <details><summary>Show example(s)</summary>{{< highlight yaml >}}
|`busPath` |string |<details><summary>Disk bus path.</summary>Warning: This requires special configuration for NVMe drives. For details, see https://github.com/siderolabs/go-blockdevice/issues/114.</details> <details><summary>Show example(s)</summary>{{< highlight yaml >}}
busPath: /pci0000:00/0000:00:17.0/ata1/host0/target0:0:0/0:0:0:0
{{< /highlight >}}{{< highlight yaml >}}
busPath: /pci0000:00/*
Expand Down
6 changes: 3 additions & 3 deletions website/content/v1.9/schemas/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2245,9 +2245,9 @@
"busPath": {
"type": "string",
"title": "busPath",
"description": "Disk bus path.\n",
"markdownDescription": "Disk bus path.",
"x-intellij-html-description": "\u003cp\u003eDisk bus path.\u003c/p\u003e\n"
"description": "Disk bus path.\nWarning: This requires special configuration for NVMe drives. For details, see https://github.com/siderolabs/go-blockdevice/issues/114.\n",
"markdownDescription": "Disk bus path.\nWarning: This requires special configuration for NVMe drives. For details, see https://github.com/siderolabs/go-blockdevice/issues/114.",
"x-intellij-html-description": "\u003cp\u003eDisk bus path.\nWarning: This requires special configuration for NVMe drives. For details, see \u003ca href=\"https://github.com/siderolabs/go-blockdevice/issues/114\" target=\"_blank\"\u003ehttps://github.com/siderolabs/go-blockdevice/issues/114\u003c/a\u003e.\u003c/p\u003e\n"
}
},
"additionalProperties": false,
Expand Down

0 comments on commit d8b6521

Please sign in to comment.