Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

talosctl gen config prints logs to stdout which breaks new --output-types X -o - argument flow #6676

Closed
james-callahan opened this issue Dec 23, 2022 · 0 comments · Fixed by #6677
Closed

talosctl gen config prints logs to stdout which breaks new --output-types X -o - argument flow #6676

james-callahan opened this issue Dec 23, 2022 · 0 comments · Fixed by #6677
Assignees
@smira
Milestone
v1.4

Comments

@james-callahan
Copy link
Contributor

Bug Report

Description

talosctl gen config asd https://asd -t talosconfig -o - --with-secrets secrets.yaml stdout is prefixed with:

generating PKI and tokens

This makes the output invalid yaml.

The informational output should instead go to stderr.

Environment

  • Talos version: 1.3.0
  • Platform: linux
@smira smira added this to the v1.4 milestone Dec 23, 2022
@smira smira self-assigned this Dec 23, 2022
smira added a commit to smira/talos that referenced this issue Dec 23, 2022
@smira
fix: send diagnostic output to stderr consistently
3f0f830 
Fixes siderolabs#6676

There was a mix of stdout/stderr, move more consistently to stderr.

Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
@smira smira mentioned this issue Dec 23, 2022
Merged
smira added a commit to smira/talos that referenced this issue Dec 23, 2022
@smira
fix: send diagnostic output to stderr consistently
fbaf5a1 
Fixes siderolabs#6676

There was a mix of stdout/stderr, move more consistently to stderr.

Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
smira added a commit to smira/talos that referenced this issue Dec 27, 2022
@smira
fix: send diagnostic output to stderr consistently
8a9ff25 
Fixes siderolabs#6676

There was a mix of stdout/stderr, move more consistently to stderr.

Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
(cherry picked from commit a0c0352)
DJAlPee pushed a commit to DJAlPee/talos that referenced this issue May 22, 2023
@smira
fix: send diagnostic output to stderr consistently
72eac53 
Fixes siderolabs#6676

There was a mix of stdout/stderr, move more consistently to stderr.

Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

fix: send diagnostic output to stderr consistently smira/talos
2 participants
@smira @james-callahan