Talos fails to parse vlan cmdline parameter if the interface uses a VLAN_PLUS_VID form

[solidDoWant]

Bug Report

Description

According to the dracut man page, there are four different forms of VLAN names:

• VLAN_PLUS_VID (vlan0005)
• VLAN_PLUS_VID_NO_PAD (vlan5)
• DEV_PLUS_VID (eth0.0005)
• DEV_PLUS_VID_NO_PAD (eth0.5)

When parsing the parameter, the parsing function assumes that the field uses either the DEV_PLUS_VID form or the DEV_PLUS_VID_NO_PAD form.

Instead, the function should do the following:

var vlanNumberString string
if strings.HasPrefix(vlanName, "vlan") {
    vlanNumberString = strings.TrimPrefix(vlanName, "vlan")
} else {
    _, vlanNumberString, ok := strings.Cut(vlanName, ".")
    if !ok {
        return settings, fmt.Errorf("malformed vlan commandline argument: %s", *vlanSettings)
    }
}

Logs

Environment

• Talos version: v1.8.1
• Kubernetes version: N/A
• Platform: metal/amd64